Skip to content

Redshift: Support implicit string concatenation using newline#2167

Merged
iffyio merged 1 commit intoapache:mainfrom
yoavcloud:redshift_concat_strings_newline
Jan 29, 2026
Merged

Redshift: Support implicit string concatenation using newline#2167
iffyio merged 1 commit intoapache:mainfrom
yoavcloud:redshift_concat_strings_newline

Conversation

@yoavcloud
Copy link
Contributor

We've encountered a statement of the following form that failed to parse due to a missing comma, that is accepted by Redshift:

SELECT 'ab' IN (
   'a'
   'b'
)

Turns out Redshift considers the 'a' <NEWLINE> 'b' as a concatenation, so it's evaluted as 'ab'. The fix here is to parse this construct as 'ab'.

@yoavcloud yoavcloud force-pushed the redshift_concat_strings_newline branch from 0062599 to e05a766 Compare January 20, 2026 18:16
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yoavcloud!

@iffyio iffyio added this pull request to the merge queue Jan 29, 2026
Merged via the queue into apache:main with commit 62cf16f Jan 29, 2026
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants