Skip to content

Conversation

@l3ender
Copy link
Contributor

@l3ender l3ender commented Nov 11, 2019

This PR resolves #74.

@l3ender l3ender marked this pull request as ready for review November 11, 2019 19:20
@l3ender
Copy link
Contributor Author

l3ender commented Nov 11, 2019

@brodybits Travis CI seems to be pokey today, but this should be good to go (verified by running stryker locally).

Copy link

@brody4hire brody4hire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I did verify (manually) that the mutations I raised in #74 would trigger failures with these changes. Merging now.

I would love it if we could improve some of the coding style, someday.

@brody4hire brody4hire merged commit 0d13735 into apache:master Nov 11, 2019
@l3ender l3ender deleted the add-target-dependency-coverage branch November 12, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal pbxProject.prototype.addTargetDependency function not properly tested

2 participants