Test coverage: addTarget add to main project as dependency#76
Merged
brody4hire merged 2 commits intoapache:masterfrom Oct 21, 2019
Merged
Test coverage: addTarget add to main project as dependency#76brody4hire merged 2 commits intoapache:masterfrom
addTarget add to main project as dependency#76brody4hire merged 2 commits intoapache:masterfrom
Conversation
brody4hire
approved these changes
Oct 21, 2019
brody4hire
left a comment
brody4hire
left a comment
There was a problem hiding this comment.
I just manually verified that the added test covers the mutation that I reported in #73 and would cover the last surviving mutant that I discovered in PR #56, merging now. I do have a couple of low-priority comments that we may want to address someday:
I noticed we needed a workaround to pass on Node.js 6. I hope we can drop Node.js 6 support in the near future, just raised #77. I think it would be ideal if we can remove the workaround once we do drop Node.js 6.
I have a feeling (and just a feeling) that it should be possible to make the UUID search process a little more intuitive. I hope to look into this someday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #73.