Skip to content

Test coverage for app_extension target types #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brody4hire merged 5 commits into from
Oct 17, 2019
Merged

Test coverage for app_extension target types #66

brody4hire merged 5 commits into from
Oct 17, 2019

Conversation

@l3ender
Copy link
Contributor

@l3ender l3ender commented Oct 17, 2019 •
edited
Loading

Resolves #63 by adding more extensive coverage for target types that can be added to a project.

@l3ender l3ender marked this pull request as ready for review October 17, 2019 01:33
@l3ender l3ender mentioned this pull request Oct 17, 2019
Closed
brody4hire
brody4hire reviewed Oct 17, 2019
View reviewed changes
Copy link

@brody4hire brody4hire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @l3ender for taking care of this.

I tried the mutations listed in #63 by hand and they do seem to be covered by the proposed updates.

I did leave a couple of comments. Not critical but I would like to get them fixed, if possible.

l3ender and others added 3 commits October 16, 2019 20:55
@l3ender l3ender mentioned this pull request Oct 17, 2019
Merged
brody4hire
brody4hire approved these changes Oct 17, 2019
View reviewed changes
Copy link

@brody4hire brody4hire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all of the requested changes, merging now.

@brody4hire brody4hire merged commit 0d3304c into apache:master Oct 17, 2019
@l3ender l3ender deleted the app-extension-test-coverage branch October 17, 2019 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brody4hire brody4hire brody4hire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build of app_extension target is not covered by test suite

2 participants

@l3ender @brody4hire