Skip to content

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Nov 16, 2017

Upgrades Jetty to Java8 compatible version

Pinging for review @marcaurele @nvazquez @borisstoyanov @DaanHoogland @wido and others

@blueorangutan package

Upgrades Jetty to Java8 compatible version

Signed-off-by: Rohit Yadav <[email protected]>
@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1260

@wido wido added this to the 4.11 milestone Nov 16, 2017
@wido
Copy link
Contributor

wido commented Nov 16, 2017

What would be the easiest way to test? Just create a DEB and run it?

@marcaurele
Copy link
Member

@wido The problem upgrading to jetty 9.3 or 9.4 is the wiremock dependency which forces the use of jetty 9.2. The dependency is only used by cloudian module. I was looking to push an upgrade to 9.4 along with the new gzip handler and a context redirect. I haven't found the time to find a solution for the wiremock dependency.

@yadvr
Copy link
Member Author

yadvr commented Nov 16, 2017

@wido yes, building a package and testing that management server works as expected is a valid regression test.
Thanks @marcaurele -- last time I tried using Jetty 9.4.x, I faced issues around server configuration which is why I dropped to using 9.2.x for the fatjar PR. The wiremock stuff is used only for writing unit tests for the cloudian plugin, I don't see how they are related to Jetty/running mgmt server. I'll close this PR in favour of your PR #2329, thanks.

@yadvr yadvr closed this Nov 16, 2017
@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants