Closed
Conversation
Collaborator
Member
|
there are several issues with this PR I created a PR for vpc in project: #209 |
vishesh92
reviewed
Aug 26, 2025
| Schema: map[string]*schema.Schema{ | ||
| "filter": dataSourceFiltersSchema(), | ||
|
|
||
| "projectid": { |
Member
There was a problem hiding this comment.
There is already a field project. Can't we use that instead?
vishesh92
reviewed
Aug 26, 2025
| Schema: map[string]*schema.Schema{ | ||
| "filter": dataSourceFiltersSchema(), | ||
|
|
||
| "projectid": { |
Member
There was a problem hiding this comment.
There is already a field project. Can't we use that instead?
Member
|
@JSpon Could you please resolve the review comments |
Member
|
@JSpon could you please let us know if you want the PR in the upcoming release? Currently, we need the PR to pass the tests and the conflicts must be resolved inorder to merge it |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several data sources and resources have project support. This is to add it to more data sources and resources.