Merged
Conversation
Contributor
Author
|
Fixes #85 |
vishesh92
approved these changes
May 9, 2024
Member
vishesh92
left a comment
vishesh92
left a comment
There was a problem hiding this comment.
code looks good to me.
Need to verify if the new methods work as expected.
vishesh92
reviewed
May 9, 2024
Comment on lines
+70
to
+72
| "registerUserData": true, | ||
| "setupUserTwoFactorAuthentication": true, | ||
| "validateUserTwoFactorAuthenticationCode": true, |
Member
There was a problem hiding this comment.
The code for these 3 commands is not being generated since they are not defined in generate/layout.go.
Contributor
Author
There was a problem hiding this comment.
Correct, but they're calls that I wanted to ensure use post when and if they do get added.
Member
Verified createUser & updateUser methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a set to contain the API names that should use POST. Not all defined API names here are actually generated by this client yet (namely the 2FA and registerUserData APIs), but would want to be POST when they're introduced.
Note this also fixes a typo in the listApis.json which actually resides upstream core cloudstack, in the OpenDaylight API descriptions.
It seems
listApis.jsonwas recently updated without calling generate, because without fixing the typo here it wants to introduce the typo into the generated code. So I am stuck with a choice between committing a change to listApis or committing a typo to the generated bindings.