Restore methods with optional params for 4.19 compatability#80
Merged
shwstppr merged 3 commits intoapache:mainfrom Mar 14, 2024
Merged
Restore methods with optional params for 4.19 compatability#80shwstppr merged 3 commits intoapache:mainfrom
shwstppr merged 3 commits intoapache:mainfrom
Conversation
c2b957e to
3331712
Compare
Member
|
@vishesh92 |
Member
|
I checked the diff betwen this PR and latest v2.15.0
|
yadvr
approved these changes
Mar 13, 2024
Member
|
thanks @vishesh92 it looks terraform will not work |
weizhouapache
approved these changes
Mar 14, 2024
Member
weizhouapache
left a comment
There was a problem hiding this comment.
checked the diff between v2.15.0 and this PR, did not find other compatibility issues except the guest OS
I think it is good to merge. @vishesh92 thanks
shwstppr
pushed a commit
that referenced
this pull request
May 9, 2024
After merging PR #80, optional params always needs to be set. In case of the optional parameter of type UUID, the only option is to set the value to an empty string. This results in a request to ACS with the optional parameter in the request with an empty string. ACS throws an error because it can't find the associated id in the database. Actual change is only in generate.go. Rest of the changes are in generated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional params from #77 to the
requiredParams.go.