Skip to content

Comments

adding updateVlanIpRange#75

Merged
DaanHoogland merged 3 commits intoapache:mainfrom
poddm:updateVlanIpRange
Dec 1, 2023
Merged

adding updateVlanIpRange#75
DaanHoogland merged 3 commits intoapache:mainfrom
poddm:updateVlanIpRange

Conversation

@poddm
Copy link
Contributor

@poddm poddm commented Nov 27, 2023

@DaanHoogland
Copy link
Contributor

according to https://github.com/apache/cloudstack-go/actions/runs/7012770058/job/19085665052?pr=75#step:6:943 this is not tested in the H action.
Code looks good but that test needs fixing. Do you care to take the time @poddm ?

@poddm
Copy link
Contributor Author

poddm commented Nov 28, 2023

@DaanHoogland, updated test data for createVlanIpRange, updateVlanIpRange, listVlanIpRanges and deleteVlanIpRange.

$ /opt/homebrew/bin/go test -timeout 30s -run ^TestVLANService$ github.com/apache/cloudstack-go/v2/test -v
=== RUN   TestVLANService
=== RUN   TestVLANService/CreateVlanIpRange
=== RUN   TestVLANService/DedicateGuestVlanRange
=== RUN   TestVLANService/DeleteVlanIpRange
=== RUN   TestVLANService/ListDedicatedGuestVlanRanges
    VLANService_test.go:82: Skipping as no json response is provided in testdata
=== RUN   TestVLANService/ListVlanIpRanges
=== RUN   TestVLANService/ReleaseDedicatedGuestVlanRange
    VLANService_test.go:106: Skipping as no json response is provided in testdata
=== RUN   TestVLANService/ListGuestVlans
    VLANService_test.go:118: Skipping as no json response is provided in testdata
=== RUN   TestVLANService/UpdateVlanIpRange
--- PASS: TestVLANService (0.00s)
    --- PASS: TestVLANService/CreateVlanIpRange (0.00s)
    --- PASS: TestVLANService/DedicateGuestVlanRange (0.00s)
    --- PASS: TestVLANService/DeleteVlanIpRange (0.00s)
    --- SKIP: TestVLANService/ListDedicatedGuestVlanRanges (0.00s)
    --- PASS: TestVLANService/ListVlanIpRanges (0.00s)
    --- SKIP: TestVLANService/ReleaseDedicatedGuestVlanRange (0.00s)
    --- SKIP: TestVLANService/ListGuestVlans (0.00s)
    --- PASS: TestVLANService/UpdateVlanIpRange (0.00s)
PASS
ok      github.com/apache/cloudstack-go/v2/test 0.455s

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@harikrishna-patnala can you have a look?

Copy link
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@DaanHoogland DaanHoogland merged commit bfefb5b into apache:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants