Fix RoleService bug where response doesn't match struct#57
Closed
hasan07 wants to merge 2 commits intoapache:mainfrom
Closed
Fix RoleService bug where response doesn't match struct#57hasan07 wants to merge 2 commits intoapache:mainfrom
hasan07 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
We will need to fix it in the code gen. I think this is another manifestation of #55 - anything that doesn't return a list type response seems to be broken. We will need to come up with a general solution @shwstppr @rohityadavcloud |
Member
|
Agree, the changes should ideally be fixed in generator otherwise they maybe reverted the next time we update the code base against new listApis. |
Contributor
|
Should be resolved with #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example raw response:
Struct doesn't match raw response, so the unmarshaller wasn't able to unmarshal properly and the response is always empty.
This fix handles the bug.
@mlsorensen FYI