Update counter, condition and autoscale policies type in responses#119
Merged
Update counter, condition and autoscale policies type in responses#119
Conversation
Pearl1594
force-pushed
the
fix-counter-response-object
branch
from
2ea307d to
fb27f75
Compare
DaanHoogland
approved these changes
Sep 8, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, do we need to / can we add any testing for this?
kiranchavala
approved these changes
Sep 18, 2025
Member
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM, tested via terraform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect datatype for objects of autoscale vm policy and group responses.