Fix generation of otherdeployparams's setters#117
Merged
DaanHoogland merged 1 commit intoapache:mainfrom Aug 27, 2025
Merged
Conversation
Contributor
|
@vishesh92, should we do a fallback try? i.e. first try “key” and then try “name”. |
Member
Author
There is no consistency on the backend. And I don't think making two requests as part of a single method call is a good approach. |
weizhouapache
approved these changes
Aug 26, 2025
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
not tested yet
DaanHoogland
approved these changes
Aug 26, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, I don'think we can do better "on this side of the fence".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherdeployparamsfor create autoscale vm profile requires the map to have the keynameand notkey. This PR fixes the generation of the keys forotherdeployparams.Ref: apache/cloudstack-terraform-provider#173 (comment)