Merged
Conversation
yadvr
reviewed
Dec 26, 2023
yadvr
reviewed
Dec 26, 2023
config/config
Outdated
| [admin] | ||
| apikey = x2glnzn09L_gCU5LFxz_2ph7RNZQ81HPrQlRiHKDv1TnjaJAoyNnhPZR65YM_mxj2YSaKLKTFPM_849EaVg2dg | ||
| secretkey = BYAJ3_K_voCLE2CBbmweZu5dUmGCokshMg9xFb9qabOogkBPS8ARk6djrQT8w-XAsiDTDMUBYBmQsYqXeuaMKA | ||
| apikey = _QtHyvUyoVvwQKJ8dPtW7fRsdgenXWO0PyjkKyo1D8CHCMSNIMEYmOJUe57_y7JXB3OKJXF3QgZPNy80F4w1yg |
Member
Author
There was a problem hiding this comment.
Added these in the config as a sample. Reverted the change for now.
yadvr
approved these changes
Dec 26, 2023
Member
yadvr
left a comment
There was a problem hiding this comment.
On a really high level LGTM - left one remark on documentation.
Rest I request one of @harikrishna-patnala @shwstppr to help with a short review iteration and then with @borisstoyanov @vladimirpetrov to schedule QA of this, as well as review the requirements fully before passing to me for IR.
harikrishna-patnala
approved these changes
Dec 27, 2023
Member
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Code LGTM.
@vishesh92 will you be able to add some test results in the PR description, as it helps in reviewing in general.
Member
|
Merged this based on test results and approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following features:
vmactionin config which allows to set the state of VMs while creating VMsOutput
For
csbench -teardown -domain -vm -volume -networkFor
csbench -vmaction=random