GH-48181: [C++] Use FetchContent for bundled Protobuf#48183
Merged
raulcd merged 9 commits intoapache:mainfrom Nov 25, 2025
Merged
GH-48181: [C++] Use FetchContent for bundled Protobuf#48183raulcd merged 9 commits intoapache:mainfrom
raulcd merged 9 commits intoapache:mainfrom
Conversation
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting committer review
…ELEMETRY_PROTOC_EXECUTABLE so it works with FetchContent targets too
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: b4901bf Submitted crossbow builds: ursacomputing/crossbow @ actions-92d482b371
|
Member
Author
|
@github-actions crossbow submit -g r |
|
Revision: b4901bf Submitted crossbow builds: ursacomputing/crossbow @ actions-3018e6ef2f
|
Member
Author
|
@github-actions crossbow submit -g cpp -g r |
|
Revision: 7919c19 Submitted crossbow builds: ursacomputing/crossbow @ actions-f0723051de
|
github-actions
bot
added
awaiting review
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
github-actions
bot
removed
awaiting review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a17e247. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
This was referenced Jan 5, 2026
kou
added a commit
that referenced
this pull request
Jan 6, 2026
…d_dependencies (#48726) ### Rationale for this change We need to update `ARROW_BUNDLED_STATIC_LIBS` in the parent scope because GH-48183 changed to `function(build_protobuf)` from `macro(build_protobuf)`. ### What changes are included in this PR? Update `ARROW_BUNDLED_STATIC_LIBS` in the parent scope. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #48725 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As a follow up of requiring a minimum CMake version >= 3.25 we discussed moving our dependencies from ExternalProject to FetchContent. This can simplify our third party dependency management. Moving Protobuf is the next step before moving gRPC.
What changes are included in this PR?
The general change is moving from
ExternalProjecttoFetchContent.It also add some required integration due to other dependencies, like gRPC, using
ExternalProject. We not only have to build but also install in order for those other dependencies to find Protobuf. This causes some timing issues between config, build, install that requires us to create a custom target to depend on so the other dependencies find Protobuf.Are these changes tested?
Yes, the changes are tested locally and on CI.
Are there any user-facing changes?
No