GH-47241: [C++][Parquet] Fix VariantExtensionType conversion#47242
GH-47241: [C++][Parquet] Fix VariantExtensionType conversion#47242pitrou merged 3 commits intoapache:mainfrom
Conversation
|
|
cpp/src/parquet/types.cc
Outdated
There was a problem hiding this comment.
I need to add this, otherwise the check will fail at
arrow/cpp/src/parquet/schema.cc
Lines 341 to 350 in 596a60f
There was a problem hiding this comment.
// For backward compatibility, assign equivalent legacy converted type (if possible)I don't think it's legacy... Should we split a new branch?
if (logical_type_->is_variant()) {
} else if (...)
There was a problem hiding this comment.
I believe the word legacy is for converted type because it also includes (if possible).
|
@wgtmac Do you know anything about the ORC build failures on the macOS CI builds? |
Ah, perhaps you can rebase to make CI green, then? |
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
7102bb6 to
9940c64
Compare
|
Yes, just rebased. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ca21204. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
…pache#47242) ### Rationale for this change The test case of VariantExtensionType is incomplete. We need to make sure its conversion is well covered. ### What changes are included in this PR? Fix all issues for VariantExtensionType conversion and add it to test. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#47241 Lead-authored-by: Gang Wu <ustcwg@gmail.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
The test case of VariantExtensionType is incomplete. We need to make sure its conversion is well covered.
What changes are included in this PR?
Fix all issues for VariantExtensionType conversion and add it to test.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.