chore: Focus on actual errors by removing -warnings-as-errors#53
Closed
dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
dongjoon-hyun:ignore-warnings
Closed
chore: Focus on actual errors by removing -warnings-as-errors#53dongjoon-hyun wants to merge 1 commit intoapache:mainfrom dongjoon-hyun:ignore-warnings
-warnings-as-errors#53dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
dongjoon-hyun:ignore-warnings
Conversation
Member
Author
|
cc @kou |
Member
Author
|
All Swift versions (5.10, 6.0, 6.1) passed. Instead of focusing on warnings, we need to focus other stuffs first. For example,
If you don't mind, why don't we call it a day for |
-warnings-as-errors
Member
|
Hmm. I don't want to remove this as much as possible to keep healthy code. |
Member
Author
|
Got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What's Changed
This PR aims to focus on real errors by removing
-warnings-as-errorsflag.To make it sure, this PR removes the following from CI test pipelines.
arrow-swift/.github/workflows/test.yaml
Lines 89 to 90 in b6ca546
We can enable
-warnings-as-errorslater .