-
Notifications
You must be signed in to change notification settings - Fork 46
Description
Current problem
.gitmodules currently contains:
[submodule "noizdns"]
path = noizdns
url = https://github.com/anonvector/noizdns.gitbut that URL is not publicly accessible right now:
git ls-remote https://github.com/anonvector/noizdns.gitreturns:
remote: Repository not found.
fatal: repository 'https://github.com/anonvector/noizdns.git/' not found
Repro
Fresh public clone:
git clone https://github.com/anonvector/SlipNet.git
cd SlipNet
git submodule update --init --recursiveThis fails at noizdns with:
Cloning into '.../SlipNet/noizdns'...
remote: Repository not found.
fatal: repository 'https://github.com/anonvector/noizdns.git/' not found
fatal: clone of 'https://github.com/anonvector/noizdns.git' into submodule path '.../SlipNet/noizdns' failed
Failed to clone 'noizdns' a second time, aborting
Why this matters
The README still documents recursive checkout for both Android build and CLI source build.
Also, the CLI is currently source-blocked by this dependency:
cli/go.modhasreplace noizdns => ../noizdnscli/main.goimportsnoizdns/mobile
So go build ./cli fails when ../noizdns is missing.
Important history / likely regression
The repo history already seems to document this exact issue:
882dde3—Remove noizdns submodule from .gitmodules (private repo breaks CI)ced2ce2—Restore noizdns submodule with PAT for CI
This makes it look like CI works because GitHub Actions uses a token for recursive submodule checkout, but public users do not have that token.
Additional note
app/build.gradle.kts appears to consume committed AARs from app/libs/golibs-full.aar and app/libs/golibs-lite.aar, so the Android Gradle path may not actually need a public noizdns checkout for normal builds.
Suggested fixes
One of these would probably resolve the public build story:
- Remove
noizdnsfrom.gitmodulesagain if it is intended to stay private. - Update the README so public users are not told to do recursive checkout that is guaranteed to fail.
- If
noizdnsis supposed to be public, update.gitmodulesto the correct public URL. - For the CLI, either vendor/publish the needed
noizdnsmodule or gate NoizDNS support so DNSTT/Slipstream CLI source builds still work without the private repo.