This repository was archived by the owner on Oct 17, 2025. It is now read-only.
deps(selenium-webdriver): upgrade to 3.0.0#63
Merged
cnishina merged 5 commits intoangular:betafrom Nov 8, 2016
Merged
Conversation
Contributor
|
Looks like selenium-webdriver uses rest parameters, which are only in Node > 6. Their package.json also shows that they require Node 6.9.0 or greater. |
- use promise object's isPending `deferred.promise.isPending` - `deferred.isPending` has been deprecated as of selenium-webdriver 3.0.0 - see SeleniumHQ/selenium@e5d67a7#diff-08a6a8d91f29fca8cebfc8671e4ffc3d
- selenium-webdriver 3.0.0 requires node >= 6.9.0
Contributor
Author
|
Adding requirements for node >= 6.9.0 per selenium-webdriver 3.0.0. |
- isPending exists in lib/promise but it is not exported - the return object was a ManagedPromise and isPending is not a class method - wrote my own isPending similar to selenium-webdriver in common.js
heathkit
approved these changes
Nov 8, 2016
cnishina
added a commit
to cnishina/jasminewd
that referenced
this pull request
Jan 6, 2017
fix test "should wait till the expect to run the flow" - `isPending` exists but it is no longer part of `ManagedPromise` - `isPending` also is no longer exported in `lib/promise.js` - wrote an `isPending` similar to selenium-webdriver in common.js require a minimum node version - selenium-webdriver 3.0.0 requires node >= 6.9.0 - update travis test to use node 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.