Skip to content

fix(@angular/cli): ensure analytics postinstall script is ES5#15620

Merged
mgechev merged 1 commit intoangular:8.3.xfrom
clydin:postinstall-es5
Sep 18, 2019
Merged

fix(@angular/cli): ensure analytics postinstall script is ES5#15620
mgechev merged 1 commit intoangular:8.3.xfrom
clydin:postinstall-es5

Conversation

@clydin
Copy link
Member

@clydin clydin commented Sep 17, 2019

This can potentially execute on very old versions of Node.js and can crash otherwise. The ng command itself has an initial Node.js version check that will then inform the user of the required minimum.

This can potentially execute on very old versions of Node.js.  The `ng` command itself has an initial Node.js version check that will then inform the user of the required minimum.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Sep 17, 2019
@mgechev mgechev merged commit 2fc0f9f into angular:8.3.x Sep 18, 2019
@clydin clydin deleted the postinstall-es5 branch September 18, 2019 13:50
This was referenced Sep 18, 2019
This was referenced Sep 23, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants