Ivy app shell #15517
Merged
Ivy app shell #15517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
commented
Sep 4, 2019
packages/schematics/angular/universal/files/src/__main@stripTsExtension__.ts.template
Outdated
Show resolved
Hide resolved
…ault for server builder BREAKING CHANGE: bundleDependencies default value has been changed from none to all. This will result in all of node_modules to be bundled in the final server bundle. Under Ivy, if users choose to opt-out from bundling dependencies they will need to run NGCC binary manually to make non-bundled node_modules compatible with Ivy.
…n file This will be used by universal and app-shell to render the server module
clydin
requested changes
Sep 5, 2019
packages/schematics/angular/migrations/update-9/update-server-main-file.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Sep 5, 2019
vikerman
approved these changes
Sep 5, 2019
packages/schematics/angular/migrations/update-9/update-server-main-file.ts
Show resolved
Hide resolved
…ver main file This is to reduce the steps for users when opting-out of ivy
…in server file Update the `main.server.ts` file by adding exports to `renderModule` and `renderModuleFactory` which are now required for Universal and App-Shell for Ivy and `bundleDependencies`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(@angular-devkit/build-angular): enable bundleDependencies by default for server builder
BREAKING CHANGE: bundleDependencies default value has been changed from none to all. This will result in all of node_modules to be bundled in the final server bundle.
Under Ivy, if users choose to opt-out from bundling dependencies they will need to run NGCC binary manually to make non-bundled node_modules compatible with Ivy.
feat(@schematics/angular): add export to
renderModulein server main fileThis will be used by universal and app-shell to render the server module
fix(@angular-devkit/build-angular): make app-shell work with Ivy
Fixes #15383
feat(@schematics/angular): add export to
renderModuleFactoryin server main filefeat(@schematics/angular): add migration to add missing exports in main server file
Update the
main.server.tsfile by adding exports torenderModuleandrenderModuleFactorywhich are now required for Universal and App-Shell for Ivy andbundleDependencies.