[Sample] [Graphics] [Compose] UltraHDR image rendering in Compose. #89
Merged
[Sample] [Graphics] [Compose] UltraHDR image rendering in Compose. #89
Conversation
…lar android view)) and Image (Compose)) to display functionality and support of rendering an ultrahdr.
MayuriKhinvasara
added
enhancement
MayuriKhinvasara
changed the title
yrezgui
requested changes
Sep 4, 2023
...dr/src/main/java/com/example/platform/graphics/ultrahdr/display/DisplayingUltraHDRCompose.kt
Outdated
Show resolved
Hide resolved
...dr/src/main/java/com/example/platform/graphics/ultrahdr/display/DisplayingUltraHDRCompose.kt
Outdated
Show resolved
Hide resolved
...dr/src/main/java/com/example/platform/graphics/ultrahdr/display/DisplayingUltraHDRCompose.kt
Outdated
Show resolved
Hide resolved
…to ultrahdr_compose_display_view
…ctivity color mode controls for hdr and sdr (3) Remove fragment class and use the Sample annotation (4) Resolve minor readability comments
yrezgui
reviewed
Sep 7, 2023
yrezgui
requested changes
Sep 7, 2023
Contributor
yrezgui
left a comment
yrezgui
left a comment
There was a problem hiding this comment.
Make sure you're updating only the right sample dependencies
Contributor
Author
Updated, Ack |
Contributor
|
@yrezgui Is there any more blockers on this one? |
* Update DisplayUltraHDRScreen logic to be Compose friendly * Add ImageView below to Compose Image composable Fetch colorMode details when screen is rendered * Update README.md
yrezgui
force-pushed
the
ultrahdr_compose_display_view
branch
from
10f0c80 to
11c18c4
Compare
yrezgui
approved these changes
Dec 7, 2023
| ) | ||
|
|
||
| @Composable | ||
| fun RenderComposeView() { |
Contributor
There was a problem hiding this comment.
Following convention across other Compose samples
Suggested change
| fun RenderComposeView() { | |
| fun RenderComposeScreen() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This CL contains sample code for rendering UltraHDR Images in Compose (on API 34 and above).
How Has This Been Tested?
Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)
Checklist
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
Screenshots
