NetworkPlugin update: adding url collector arg and test enhancements#120
Open
jaspals3123 wants to merge 7 commits intodevelopmentfrom
Open
NetworkPlugin update: adding url collector arg and test enhancements#120jaspals3123 wants to merge 7 commits intodevelopmentfrom
jaspals3123 wants to merge 7 commits intodevelopmentfrom
Conversation
jaspals3123
requested review from
alexandraBara and
landrews-amd
as code owners
alexandraBara
requested changes
Feb 2, 2026
Collaborator
|
Please update the functional test for this plugin and add the collector arg to the plugin_config: https://github.com/amd/node-scraper/blob/development/test/functional/fixtures/network_plugin_config.json |
alexandraBara
changed the title
alexandraBara
requested changes
Feb 3, 2026
Comment on lines
+1706
to
+1708
| description="System networking is up", | ||
| data={"url": url, "accessible": result.exit_code == 0}, | ||
| priority=EventPriority.INFO, |
Collaborator
There was a problem hiding this comment.
description=f"Network connectivity check successful: {cmd} to {url} succeeded",
data={"url": url, "command": cmd, "accessible": True},
priority=EventPriority.INFO,
console_log=True,
| category=EventCategory.NETWORK, | ||
| description=f"{cmd} to {url} failed!", | ||
| data={"url": url, "not accessible": result.exit_code == 0}, | ||
| priority=EventPriority.ERROR, |
Collaborator
There was a problem hiding this comment.
add this: console_log=True
alexandraBara
requested changes
Feb 4, 2026
Collaborator
alexandraBara
left a comment
alexandraBara
left a comment
There was a problem hiding this comment.
we need to log this to console as well and improve the messaging so we know which cmd and what url was used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.