Skip to content

[Infra] IDE follow-ups of scikit-build-core. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oraluben merged 1 commit into from
Oct 16, 2023
Merged

[Infra] IDE follow-ups of scikit-build-core. #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,7 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror=implicit-function-declaration")

# Only for IDE linting, skbuild will handle wheel dependencies.
if (NOT SKBUILD)
# set(PYTHON_ROOT "")
if (NOT SKBUILD_ASSETS)
FILE(GLOB SKBUILD_ASSETS RELATIVE ${PYTHON_ROOT} "${PYTHON_ROOT}/lib/python*/site-packages/skbuild/resources/cmake")
endif ()
if (NOT PYTHON_ROOT OR NOT SKBUILD_ASSETS)
message(FATAL_ERROR "Need to specify `PYTHON_ROOT` for the targeting python interpreter and `SKBUILD_ASSETS` for scikit-build cmake files (can be ignored if the installed in the target python).")
endif ()
set(CMAKE_MODULE_PATH "${CMAKE_MODULE_PATH};${PYTHON_ROOT}/${SKBUILD_ASSETS}")

FILE(GLOB include RELATIVE ${PYTHON_ROOT} ${PYTHON_ROOT}/include/python*)
FILE(GLOB libpython RELATIVE ${PYTHON_ROOT} ${PYTHON_ROOT}/lib/libpython*)

set(PYTHON_EXECUTABLE "${PYTHON_ROOT}/bin/python3")
set(PYTHON_INCLUDE_DIR "${PYTHON_ROOT}/${include}")
set(PYTHON_LIBRARY "${PYTHON_ROOT}/${libpython}")
#set(Python_ROOT_DIR "")
endif ()

find_package(Python 3.8 REQUIRED COMPONENTS Interpreter Development.Module)
Expand All @@ -30,7 +16,7 @@ add_compile_definitions(NEED_OPCODE_TABLES) # for _PyOpcode_Caches and _PyOpcod

python_add_library(_cds MODULE WITH_SOABI src/_cds/_cdsmodule.c src/_cds/lookup_table.c src/_cds/hashtable.c)
# clinic-generated files access core header.
target_include_directories(_cds PRIVATE "${PYTHON_INCLUDE_DIR}/internal")
target_include_directories(_cds PRIVATE "${Python_INCLUDE_DIRS}/internal")

# todo: if find cpython repo, run clinic
# currently we manually run `python3 ../cpython/Tools/clinic/clinic.py --make --srcdir src/_cds`
Expand Down