📝 [REPO]: Added CONTRIBUTING.md with contribution guidelines to the r…#2279
Draft
rohitjethoe wants to merge 1 commit intoairbnb:masterfrom
rohitjethoe:repo/contributing.md
Draft
📝 [REPO]: Added CONTRIBUTING.md with contribution guidelines to the r…#2279rohitjethoe wants to merge 1 commit intoairbnb:masterfrom rohitjethoe:repo/contributing.md
rohitjethoe wants to merge 1 commit intoairbnb:masterfrom
rohitjethoe:repo/contributing.md
Conversation
ljharb
requested changes
Aug 26, 2020
|
|
||
| #### For new Contributors | ||
|
|
||
| If you never created a pull request before, welcome 🎉 😄 [Here](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github) is a great tutorial on how to send one :) |
Collaborator
There was a problem hiding this comment.
videos aren't all that accessible, and this particular site/content is used as an enticement to sell access to further videos - can we find different content to link to?
Comment on lines
+44
to
+51
| Good pull requests - patches, improvements, new features - are a fantastic | ||
| help. They should remain focused in scope and avoid containing unrelated | ||
| commits. | ||
|
|
||
| **Please ask first** before embarking on any significant pull request (e.g. | ||
| implementing features, refactoring code), otherwise you risk spending a lot of | ||
| time working on something that the project's developers might not want to merge | ||
| into the project. |
Collaborator
There was a problem hiding this comment.
This is good advice for projects in general, but in this project, pretty much the only changes that are expected/welcome from non-maintainers are:
- things with the pull request wanted label
- updating the eslint config to match the guide
- editorial improvements to the guide
In particular, it should be noted that no "normative" (ie, things that alter the spirit of how you're recommended to write code) guide or eslint config changes will be made unless it's initiated by current Airbnb employees, so it's not a good use of time to propose any.
yezz123
approved these changes
Jan 6, 2021
cosmicle0
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repo/contributing.md
Added CONTRIBUTING.md with contribution guidelines to the repo.
This can be useful for new github contributors who are finding for open source contribution opportunities.
Fixes #2033