Fix incorrect timing parameter passed to run_scanners#4783
Open
codewithfourtix wants to merge 3 commits intoaboutcode-org:developfrom
Open
Fix incorrect timing parameter passed to run_scanners#4783codewithfourtix wants to merge 3 commits intoaboutcode-org:developfrom
codewithfourtix wants to merge 3 commits intoaboutcode-org:developfrom
Conversation
The run_scanners call was passing 'timeout' (a float, default 120.0) as the 'timing' argument instead of the 'timing' boolean flag. This caused per-file scan timings to always be collected regardless of the --timing CLI option. Signed-off-by: codewithfourtix <codewithfourtix@gmail.com>
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect argument being passed to run_scanners() from the main scan orchestration path (run_scan()), so that per-file scan timing collection correctly follows the --timing CLI flag rather than being implicitly enabled by the (truthy) timeout value.
Changes:
- Correct
run_scanners(..., timing=...)to use thetimingboolean instead oftimeout. - Restores expected CLI behavior where per-file scan timings are only collected when
--timingis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: codewithfourtix <codewithfourtix@gmail.com>
Remove incorrect @pytest.mark.scanslow and @pytest.mark.skipif decorators that were accidentally copied from the test above. This test should run on all platforms including Windows. Signed-off-by: codewithfourtix <codewithfourtix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
timing=timeouttypo inrun_scannerscall inrun_scanThe
run_scannerscall was passingtimeout(a float, default 120.0) as thetimingargument instead of thetimingboolean flag. This caused per-file scan timings to always be collected regardless of the--timingCLI option.Tasks
Run [tests](https://scancode-toolkit.readthedocs.io/en/latest/contribute/contrib_dev.html#running-tests) locally to check for errors.