Skip to content

Realtime Multilingual Chat App#73

Merged
Srushtika merged 11 commits intoably:realtime-multilingual-chat-jsfrom
sarahchima:realtime-multilingual-chat-js
Nov 6, 2019
Merged

Realtime Multilingual Chat App#73
Srushtika merged 11 commits intoably:realtime-multilingual-chat-jsfrom
sarahchima:realtime-multilingual-chat-js

Conversation

@sarahchima
Copy link

No description provided.

Copy link

@Srushtika Srushtika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment otherwise looks good thanks!

re the file public/bundle.js - what does it do? I can see the contents of that file? Can it be removed?

index.js Outdated

//This gets the data of other users as they publish to the channel.
channel.subscribe("user", (data) => {
var dataObj = JSON.parse(JSON.stringify(data));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data object is already in JSON format by default. Can you update this in a new commit please? No need to do a new step-wise commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the tutorial one as well after having tested it, thanks.

@Srushtika
Copy link

@sarahchima please also update the README file to contain details of this specific project/ tutorial. Thanks!

@sarahchima
Copy link
Author

One small comment otherwise looks good thanks!

re the file public/bundle.js - what does it do? I can see the contents of that file? Can it be removed?

The client-side javascript is written in ES6 and has to be compiled first. The bundle.js file is where is compiled code is and that's what serves the frontend.

@Srushtika Srushtika merged commit b815d5a into ably:realtime-multilingual-chat-js Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments