Skip to content

6.8 Regression - Block Data Mangled, incorrect json_encode/json_decode usage #8735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
margolisj wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

6.8 Regression - Block Data Mangled, incorrect json_encode/json_decode usage #8735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
966a607
Updates unit tests
margolisj Apr 24, 2025
81f7bd8
This is going to be fun
margolisj Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,7 +1600,7 @@ function make_after_block_visitor( $hooked_blocks, $context, $callback = 'insert
* @return string Serialized attributes.
*/
function serialize_block_attributes( $block_attributes ) {
$encoded_attributes = wp_json_encode( $block_attributes, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );
$encoded_attributes = wp_json_encode( (object) $block_attributes, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );
$encoded_attributes = preg_replace( '/--/', '\\u002d\\u002d', $encoded_attributes );
$encoded_attributes = preg_replace( '/</', '\\u003c', $encoded_attributes );
$encoded_attributes = preg_replace( '/>/', '\\u003e', $encoded_attributes );
Expand Down
12 changes: 12 additions & 0 deletions tests/phpunit/tests/blocks/serialize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,18 @@ public function data_serialize_identity_from_parsed() {

// Block with attribute values that should not be escaped.
array( '<!-- wp:attributes {"key":"€1.00 / 3 for €2.00"} /-->' ),

// Block with attribute values that have empty keys.
array( '<!-- wp:attributes {"key":{},"nested":{"key2":{}}} /-->' ),

// Block with attribute values that have array keys.
array( '<!-- wp:attributes {"key":[],"nested":{"key2":[]}} /-->' ),

// Block with attribute values that have string numeric keys.
array( '<!-- wp:attributes {"1":"one","2":"two"} /-->' ),

// Block with attribute values that have numeric keys.
array( '<!-- wp:attributes {1:"one",2:"two"} /-->' ),
);
}

Expand Down
Loading