Blocks: Introduce a variation of serialize blocks helper with traversing#5246
Closed
gziolo wants to merge 7 commits intoWordPress:trunkfrom
Closed
Blocks: Introduce a variation of serialize blocks helper with traversing#5246gziolo wants to merge 7 commits intoWordPress:trunkfrom
gziolo wants to merge 7 commits intoWordPress:trunkfrom
Conversation
gziolo
force-pushed
the
update/traverse-and-serialize-block
branch
from
1a709d1 to
40d6697
Compare
Closed
2 tasks
ockham
reviewed
Sep 19, 2023
…_block(s) callback argument See WordPress#5242. Co-authored-by: ockham <ockham@git.wordpress.org>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
ockham
reviewed
Sep 19, 2023
| * | ||
| * @param string $original Original block markup. | ||
| */ | ||
| public function test_traverse_and_serialize_identity_from_parsed( $original ) { |
Member
There was a problem hiding this comment.
For better placement could you add this test after test_serialize_identity_from_parsed?
Member
Author
There was a problem hiding this comment.
What's the rationale behind it? Are there any recommendations regarding the order of functions in test files? It's now located next to other tests covering traverse_and_serialize_blocks.
Member
Author
There was a problem hiding this comment.
@mukeshpanchal27, I landed these changes, but I'm happy to work on a follow-up once you respond to the comment. There are two follow-up commits planned to finalize backporting Block Hooks feature from Gutenberg by @ockham that depend on this work.
…serialize_block`
Member
Author
|
Committed with https://core.trac.wordpress.org/changeset/56620. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59313.
Reverts changes from #5187 (changeset, ticket) and implements changes discussed in #5242.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.