General: Return null instead of void in paginate_links()#10999
General: Return null instead of void in paginate_links()#10999apermo wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Update `paginate_links()` to explicitly return `null` instead of void when the total number of pages is less than 2, and update the `@return` docblock to reflect this change. Fixes #64694.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| $total = (int) $args['total']; | ||
| if ( $total < 2 ) { | ||
| return; | ||
| return null; |
There was a problem hiding this comment.
Does it raise backward compatibility issue?
Developed in #10999 Follow-up to r32598. Props apermo, mukesh27, westonruter See #64238. Fixes #64694. git-svn-id: https://develop.svn.wordpress.org/trunk@61719 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress/wordpress-develop#10999 Follow-up to r32598. Props apermo, mukesh27, westonruter See #64238. Fixes #64694. Built from https://develop.svn.wordpress.org/trunk@61719 git-svn-id: http://core.svn.wordpress.org/trunk@61027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
3 participants
Update
paginate_links()to explicitly returnnullinstead of void when the total number of pages is less than 2, and update the@returndocblock to reflect this change.Trac ticket: https://core.trac.wordpress.org/ticket/64694#ticket
Use of AI Tools
AI used for analysis and commit message.
Fix done manually.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.