Skip to content

Move prepareForNextIteration call from Benchmark's runnerCode to preIterationCode #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmiller68 merged 1 commit into from
Jul 12, 2025
Merged

Move prepareForNextIteration call from Benchmark's runnerCode to preIterationCode #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions JetStreamDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,9 +650,6 @@ class Benchmark {
let benchmarkName = "${this.name}";

for (let i = 0; i < ${this.iterations}; i++) {
if (__benchmark.prepareForNextIteration)
__benchmark.prepareForNextIteration();

${this.preIterationCode}

const iterationMarkLabel = benchmarkName + "-iteration-" + i;
Expand All @@ -668,8 +665,7 @@ class Benchmark {

results.push(Math.max(1, end - start));
}
if (__benchmark.validate)
__benchmark.validate(${this.iterations});
__benchmark.validate?.(${this.iterations});
top.currentResolve(results);`;
}

Expand All @@ -684,7 +680,7 @@ class Benchmark {
get prerunCode() { return null; }

get preIterationCode() {
let code = "";
let code = `__benchmark.prepareForNextIteration?.();`;
if (this.plan.deterministicRandom)
code += `Math.random.__resetSeed();`;

Expand Down Expand Up @@ -1185,8 +1181,7 @@ class AsyncBenchmark extends DefaultBenchmark {
return `
async function doRun() {
let __benchmark = new Benchmark();
if (__benchmark.init)
await __benchmark.init();
await __benchmark.init?.();
let results = [];
let benchmarkName = "${this.name}";

Expand All @@ -1206,8 +1201,7 @@ class AsyncBenchmark extends DefaultBenchmark {

results.push(Math.max(1, end - start));
}
if (__benchmark.validate)
__benchmark.validate(${this.iterations});
__benchmark.validate?.(${this.iterations});
top.currentResolve(results);
}
doRun().catch((error) => { top.currentReject(error); });`
Expand Down
Loading