Skip to content

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Jan 29, 2026

Using the function source is technically not defined to always return the source string.
Additionally this forces chrome to use a special external string type since it's rather uncommon to access the function source.

Until we can fix the resource loading to handle duplicate entries for files and preload data we will duplicate the js-tokens.js file to get a separate name.

Addresses issue #271.

@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 5a6d7f4
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/697b5fcd9187d400072de78b
😎 Deploy Preview https://deploy-preview-270--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni added the v3.0-block blocking task for v3.0 release label Jan 29, 2026
@camillobruni
Copy link
Contributor Author

camillobruni commented Jan 30, 2026

I actually mis-mesured since I was doing this on the command line instead of the browser where we actually the full external string implementation:

Before (10 runs):

browser          Google Chrome Beta     Safari Technology Preview  Firefox
version          145.0.7632.26          26.0.0.234.20624.1.6.19.3  147.0.1
cpu              Apple M1 Max 10 cores  Apple M1 Max 10 cores      Apple M1 Max 10 cores
js-tokens/Score  186.0 ± 3.2%           328 ± 4.3%                 281.9 ± 1.2%
Score            186.0 ± 3.2%           328 ± 4.3%                 281.9 ± 1.2%

After (10 runs):

browser          Google Chrome Beta     Safari Technology Preview  Firefox
version          145.0.7632.26          26.0.0.234.20624.1.6.19.3  147.0.1
js-tokens/Score  347.2 ± 1.3%           324 ± 5.1%                 213.3 ± 0.60%
Score            347.2 ± 1.3%           324 ± 5.1%                 213.3 ± 0.60%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.0-block blocking task for v3.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant