Explicitly specify the default keystore location and type in keystore.xml #695
Merged
Explicitly specify the default keystore location and type in keystore.xml #695
Conversation
….xml Signed-off-by: Leo Christy Jesuraj <leojc@ca.ibm.com>
idlewis
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly specify the default keystore location and type in keystore.xml
This is a safe change to make as the added keystore location and type are the default values. But helps to avoid mismatched keystore values in scenarios where the user has also configured the keystore in their server.xml (i.e. not just the password field, but also the location and/or type). In scenarios where the keystore.xml is copied to the configDropins/defaults directory, it could be overridden by the user. In scenarios where Liberty container creates the keystore, the config written to configDropins/overrides directory would take precedence over the config in server.xml (i.e. user specified another location).