Conversation
leochr
reviewed
Apr 7, 2025
| # Create a new SCC layer | ||
| RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \ | ||
| && rm -rf /output/messaging /output/resources/security /logs/* $WLP_OUTPUT_DIR/.classCache \ | ||
| && find /opt/ibm/wlp/output ! -perm -g=rwx -print0 | xargs -0 -r chmod g+rwx |
Member
There was a problem hiding this comment.
-path "*.classCache*" should be added to match IBM Java 8 + UBI 8:
| # limitations under the License. | ||
|
|
||
|
|
||
| # TODO |
Member
There was a problem hiding this comment.
Update this comment to match the commands we run internally so that external users can also build the base image by following the same.
| rm -rf /output/workarea /output/logs; \ | ||
| find /opt/ibm/wlp ! -perm -g=rw -print0 | xargs -r -0 chmod g+rw; | ||
|
|
||
| ARG PARENT_IMAGE=icr.io/appcafe/websphere-liberty:kernel-java8-ibmjava-ubi9-minimal |
Member
There was a problem hiding this comment.
This base image with -ubi9-minimal at the end of the tag name is invalid (including for Semeru 21 based images in production). It should instead be -ubi-minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #666