VMM: HM - toggle CR4.CET around toggling CR0.WP if needed#565
Open
minipli-oss wants to merge 1 commit intoVirtualBox:mainfrom
Open
VMM: HM - toggle CR4.CET around toggling CR0.WP if needed#565minipli-oss wants to merge 1 commit intoVirtualBox:mainfrom
minipli-oss wants to merge 1 commit intoVirtualBox:mainfrom
Conversation
CET enabled systems need to disable CR4.CET prior to attempting to toggle CR0.WP to avoid triggering a #GP(0). This is needed in VMMR0.r0 for PaX's r/o GDT handling. Enhance the r/o GDT handling to toggle CR4.CET as well in case it's enabled. Signed-off-by: Mathias Krause <minipli@grsecurity.net>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CET enabled systems need to disable CR4.CET prior to attempting to toggle CR0.WP to avoid triggering a #GP(0). This is needed in VMMR0.r0 for PaX's r/o GDT handling.
Enhance the r/o GDT handling to toggle CR4.CET as well in case it's enabled.
This patch was proposed on the vbox-dev mailing list in 2024 already but never got any feedback. This is yet another attempt to get it merged.
Thanks,
Mathias