[feat] New assembly resolving pipeline + some nuget resolving heuristics#169
Open
mxprshn wants to merge 1 commit intoVSharp-team:masterfrom
Open
[feat] New assembly resolving pipeline + some nuget resolving heuristics#169mxprshn wants to merge 1 commit intoVSharp-team:masterfrom
mxprshn wants to merge 1 commit intoVSharp-team:masterfrom
Conversation
Member
mxprshn
commented
Oct 13, 2022
mxprshn
commented
- Introduce IAssemblyResolver interface for assembly name -> assembly path searchers; wrap existing Microsoft API searchers with it
- Add some IAssemblyResolver with heuristics for .NET Framework dll's from NuGet packages resolving (for example, JetBrains ReSharper API)
- Don't fail when some types cannot be resolved, work with those which can
mxprshn
force-pushed
the
assembly-resolving-fixes
branch
from
0605ee9 to
5aee199
Compare
MchKosticyn
reviewed
Oct 28, 2022
| { | ||
| if (m.GetMethodBody() != null) | ||
| global::System.Reflection.MethodBody methodBody = null; | ||
| var hasByRefLikes = true; |
Member
There was a problem hiding this comment.
Кажется, что по умолчанию лучше это выставить в false, и назвать "hasRefLikes", если имеются ввиду ref-like структуры
Member
There was a problem hiding this comment.
В .NET оно называется именно "ByRefLike", поэтому название можно оставить
Comment on lines
+212
to
+213
| methodBody = m.GetMethodBody(); | ||
| hasByRefLikes = Reflection.hasByRefLikes(m); |
Member
There was a problem hiding this comment.
Насколько я понял, эксепшен может произойти во время "m.GetMethodBody()", тогда логичнее вначале вычислить "Reflection.hasByRefLikes(m)", если это необходимо
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.