[BREAKING] Require Node.js 20.11.x/>=21.2.0 and npm >=10#928
Merged
RandomByte merged 3 commits intomainfrom Feb 20, 2024
Merged
[BREAKING] Require Node.js 20.11.x/>=21.2.0 and npm >=10#928RandomByte merged 3 commits intomainfrom
RandomByte merged 3 commits intomainfrom
Conversation
BREAKING CHANGE: Support for older Node.js and npm releases has been dropped. Only Node.js 20.11.x and >=21.2.0 as well as npm v10 or higher are supported.
This change is possible now thanks to a higher minimum Node.js version
d3xter666
reviewed
Feb 20, 2024
| uses: actions/setup-node@v4.0.2 | ||
| with: | ||
| node-version: 18.x | ||
| node-version: 20.x |
Member
There was a problem hiding this comment.
For the other repos we use 20.11.0
Should that matter here?
Member
Author
There was a problem hiding this comment.
In the other repositories we want to make sure that we always test with the minimal supported version of Node.js, which is 20.11.0 and 21.2.0.
In this particular workflow, we don't test our modules but build the documentation. Using the latest LTS version seems more reasonable here, so that we can benefit from bug fixes and improvements.
d3xter666
reviewed
Feb 20, 2024
Co-authored-by: Yavor Ivanov <d3xter666@users.noreply.github.com>
matz3
approved these changes
Feb 20, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Support for older Node.js and npm releases has been dropped.
Only Node.js 20.11.x and >=21.2.0 as well as npm v10 or higher are supported.
JIRA: CPOUI5FOUNDATION-800