Section/Text: fix shape/drawing operations in text#7
Closed
PhosCity wants to merge 1 commit intoTypesettingTools:masterfrom
Closed
Section/Text: fix shape/drawing operations in text#7PhosCity wants to merge 1 commit intoTypesettingTools:masterfrom
PhosCity wants to merge 1 commit intoTypesettingTools:masterfrom
Conversation
Author
|
I noticed that my previous commit did not consider lines with linebreakers. So I've added a new commit fixing that. The code became a bit messier due to that but lmk if there's a better way to achieve this if there is. |
PhosCity
force-pushed
the
textsection-fixes
branch
from
b556e41 to
ff84b23
Compare
Author
|
I've changed this PR to draft because this has to be revised a little bit after #9 gets merged. |
PhosCity
force-pushed
the
textsection-fixes
branch
from
ff84b23 to
3d1dde9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the convertToDrawing not working for lines with multiple linebreakers. The issues below were fixed after merging #9
The main issue was thatc - Close b-splinewas not understood by assf as valid shape data.The other issue was that when rotating, the shape data from Yutils was being passed as raw and assf complained there was missingtagProps. Instead I passed the data as string.Finally,convertToDrawingin Text section did not maintain original appearance. I've transformed the shape data so that the original shape is maintained. (Not accounting for \frx, \fax and \fay. Waiting for arch's Perspective module)