Allow repeating the command between parameters #10
Open
arch1t3cht wants to merge 1 commit intoTypesettingTools:masterfrom
Open
Allow repeating the command between parameters #10arch1t3cht wants to merge 1 commit intoTypesettingTools:masterfrom
arch1t3cht wants to merge 1 commit intoTypesettingTools:masterfrom
Conversation
Drawing strings like 'b 0 0 100 200 300 400' internally translate to something like 'b 0 0 b 100 200 b 300 400' on both libass and xy-VSFilter, so the latter string will have the same effect. This commit skips repetitions of the currently active drawing commands in parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally part of #9, but made a separate PR because it changes parsing logic.
Drawing strings like
b 0 0 100 200 300 400internally translate to something likeb 0 0 b 100 200 b 300 400on both libass and xy-VSFilter, so the latter string will have the same effect. But upon encounteringb 0 0 b 100 200 300 400, ASSFoundation will error out with a message like "incorrect number of ordinates for command 'b': expected 6, got 2".This commit skips repetitions of the currently active drawing commands in parameters. The code only triggers after encountering parameters to commands that wouldn't cast to numbers, so it shouldn't change parsing for drawing strings that assf previously considered valid. Still, it can change behavior when encountering "invalid" drawings.