fix: table handles would crash #2384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When hovering between tables of different sizes (a larger table above a smaller one), this would crash in
TableHandlesControllerbecause the table id and rowIndex / colIndex would be out of sync.Closes #2355
Rationale
This is a quick fix to fix the crash, without a test. While looking into this, we encountered some related issues that can occur when using tables and collaboration. The table component needs a larger refactoring to accommodate for this which we'll add to the roadmap. As part of that refactor we'll also make sure this scenario will be covered in tests
Changes
Reset hovered table cell / row / col state when table changes
Impact
Testing
manual testing, see above for rationale
Checklist