Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/server-util
@blocknote/react
@blocknote/shadcn
@blocknote/xl-docx-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Collaborator
|
@matthewlipski this was removed intentionally here; #1629 |
matthewlipski
changed the title
display: flex to block content
nperez0111
reviewed
May 20, 2025
Contributor
There was a problem hiding this comment.
The current spacing looks off, could we get it back to how it was before this?
Contributor
There was a problem hiding this comment.
Like there is something with the bullet list spacing to be doing this:
(where the cursor is right up to the bullet)
Collaborator
Author
There was a problem hiding this comment.
Looks like display: inline is just a nightmare. The empty list item cursor is browser-specific, and the PW snapshot has an additional space between the inline elements that you can't remove without some hacks. I'll see if I can get the selection working with flexbox.
nperez0111
reviewed
May 20, 2025
Comment on lines
-217
to
-223
| .bn-block-content[data-text-alignment="center"] { | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .bn-block-content[data-text-alignment="right"] { | ||
| justify-content: flex-end; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with the basic editor styling:
display: flexfrom.bn-block-contenton list items as this was causing the issue reported by The wrong cursor position was inserted when clicking at the end of the paragraph #1588 and missed in fix: Selection handling when clicking editor padding #1629.display: inlineto.bn-inline-content, which allows list item content to be side-by-side with the:beforeelement without usingdisplay: flexon.bn-block-content.display: flexto.bn-block-contentonly for blocks without inline content. This doesn't reintroduce the bug from The wrong cursor position was inserted when clicking at the end of the paragraph #1588 as that only affects blocks with inline content. Fixes Image alignment broken in latest update #1687 and a regression from fix: Selection handling when clicking editor padding #1629.Closes #1687