Conversation
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
acid-ant
previously approved these changes
Dec 30, 2022
alexvanin
previously approved these changes
Dec 30, 2022
cmd/frostfs-node/cache.go
Outdated
|
|
||
| return val.(*container.EACL), nil | ||
| func (s ttlEACLStorage) GetEACL(cnr cid.ID) (*container.EACL, error) { | ||
| return s.get(cnr.EncodeToString()) |
There was a problem hiding this comment.
I like how short it gets with generics.
Author
There was a problem hiding this comment.
Oh, your commment made me think, that we do not need to encode the container ID here, can use cid.ID too. Fixed.
Author
There was a problem hiding this comment.
The only problem I encountered is that you cannot define a type like type X Type[int, int] and then some methods on top of it.
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Open
alexvanin
approved these changes
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.