Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSocketServer#1223
Merged
marci4 merged 8 commits intoTooTallNate:masterfrom Mar 25, 2022
Merged
Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSocketServer#1223marci4 merged 8 commits intoTooTallNate:masterfrom
marci4 merged 8 commits intoTooTallNate:masterfrom
Conversation
Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSocketServer
|
When wrapping the |
…t just stack trace
Issue-1160 Put whole Error into Exception during Error processing, not just stack trace
…ting Erro to Exception
Contributor
Author
@Marcono1234 yeap, changed |
PhilipRoman
reviewed
Mar 25, 2022
PhilipRoman
approved these changes
Mar 25, 2022
Collaborator
|
@Serpion-ua thank you very much for your contribution! @PhilipRoman thank you for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added java.lang.Error handling in WebSocketImpl and WebSocketServer. Fatal Error ( VirtualMachineError | ThreadDeath | LinkageError ) lead to stopping of WebSocketServer. Now non-fatal Error leads to closing of web socket but not stopping of WebSocketServer.
Fixes #1160