Use appropriate schema in any case#1025
Merged
marci4 merged 2 commits intoTooTallNate:masterfrom May 24, 2020
Merged
Conversation
Collaborator
|
Hello @yindex, could you please open a PR for this issue so everyone better understands the issue. Best regards, |
Author
|
sorry, for miss that, I will open an issue with detail and Motivation for that |
Author
marci4
requested changes
May 23, 2020
Collaborator
marci4
left a comment
marci4
left a comment
There was a problem hiding this comment.
Changes look good.
Could you create two simple tests which simple check for the illegal argument exception when using http and https and no exception when using ws and wss
add unit test for schema check
yindex
force-pushed
the
master
branch
2 times, most recently
from
38a7aed to
af28db4
Compare
Author
two sample test added Best regards, |
marci4
approved these changes
May 24, 2020
Collaborator
|
@yindex thx for your changes and the tests! Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce Use appropriate schema in any case
Description
throw exception if use invalid schema in websocket client.
Related Issue
Fixes #1026
Motivation and Context
I think we should force users to use valid schema. Avoid confusion when using the invalid schema without throwing an exception
How Has This Been Tested?
Types of changes
Checklist: