Merged
Conversation
tj-wazei
previously approved these changes
Apr 16, 2024
Taz03
previously requested changes
Apr 17, 2024
Contributor
Taz03
left a comment
Taz03
left a comment
There was a problem hiding this comment.
add a sonar / checkstyle check to prevent this from happening again (as stated in the issue)
Contributor
Author
True, it's a partial resolution. But generally I prefer configuration and code changes in 2 separate PRs. As this will have no direct impact, but merging it will prevent PRs. While changing sonar configuration might for open PRs. |
SquidXTV
requested changes
May 7, 2024
...ation/src/main/java/org/togetherjava/tjbot/features/moderation/audit/ModAuditLogRoutine.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/features/mathcommands/TeXCommandTest.java
Show resolved
Hide resolved
tj-wazei
approved these changes
May 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes star imports. Resolves #1057