Skip to content

Conversation

@Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 20, 2026

API changes

List secrets: GET /api/secrets/.
Create a secret: POST /api/secrets/.
Update a secret: PUT /api/secrets/{secret_name}.
Delete a secret: DELETE /api/secrets/{secret_name}.

DB changes

class Secret(_TableBase):
    __tablename__ = "secret"
    user_id: orm.Mapped[str] = orm.mapped_column(primary_key=True, index=True)
    secret_name: orm.Mapped[str] = orm.mapped_column(primary_key=True)
    secret_value: orm.Mapped[str]
    created_at: orm.Mapped[datetime.datetime | None] = orm.mapped_column(default=None)
    updated_at: orm.Mapped[datetime.datetime | None] = orm.mapped_column(default=None)
    extra_data: orm.Mapped[dict[str, Any] | None] = orm.mapped_column(default=None)

TaskSpec changes

componentRef: ...
  spec:
    inputs:
    - {name: input4, type: Secret}
arguments:
  input1: "constant value"
  input2:
    taskOutput:
      taskId: "task1"
      outputName: "output1"
  input3:
    graphInput:
      inputName: "graph_input_1"
  # New:
  input4:
    dynamicData:
      secret:
        name: "API_TOKEN"

Fixes: #51

@Ark-kun Ark-kun added the enhancement New feature or request label Jan 20, 2026
Copy link
Collaborator

@yuechao-qin yuechao-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions/comments. Great work getting secrets working quickly!

Copy link
Collaborator

@yuechao-qin yuechao-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only major issue out of my comments would be ItemAlreadyExistsError exception handler. Others are enhancements/suggestions.

@Ark-kun Ark-kun merged commit 2f77f36 into master Feb 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

epic: Secrets

3 participants