-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Secrets #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Secrets #69
Conversation
yuechao-qin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions/comments. Great work getting secrets working quickly!
…ecret API methods
yuechao-qin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only major issue out of my comments would be ItemAlreadyExistsError exception handler. Others are enhancements/suggestions.
API changes
List secrets: GET
/api/secrets/.Create a secret: POST
/api/secrets/.Update a secret: PUT
/api/secrets/{secret_name}.Delete a secret: DELETE
/api/secrets/{secret_name}.DB changes
TaskSpec changes
Fixes: #51