fix(virtual-core): correct lane assignments when lane count changes dynamically#1095
Merged
piecyk merged 2 commits intoTanStack:mainfrom Dec 30, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 011c9b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 011c9b9
☁️ Nx Cloud last updated this comment at |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ynamically
🎯 Changes
Fixes issue where changing lane count dynamically causes layout breakage with items retaining old lane numbers, resulting in out-of-bounds errors in responsive masonry layouts.
After clearing measurements cache on lane change, the virtualizer was incorrectly restoring from initialMeasurementsCache which contained stale lane assignments.
Added check to skip initialMeasurementsCache restoration during lane transitions using the lanesSettling flag.
Related Issue: #1063
✅ Checklist
pnpm run test:pr.🚀 Release Impact