Skip to content

refactor(vue-router): Link 'from' default is handled by buildLocation like solid & react#6887

Merged
Sheraff merged 2 commits intorefactor-signalsfrom
refactor-signals-vue-link-from-arg-by-build-location
Mar 11, 2026
Merged

refactor(vue-router): Link 'from' default is handled by buildLocation like solid & react#6887
Sheraff merged 2 commits intorefactor-signalsfrom
refactor-signals-vue-link-from-arg-by-build-location

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Mar 11, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f41d1922-83e3-44f7-9016-b0db5c1cf5b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor-signals-vue-link-from-arg-by-build-location

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 11, 2026

View your CI Pipeline Execution ↗ for commit 4611e7d

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 11m 6s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-11 08:20:21 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Bundle Size Benchmarks

  • Commit: 870cf2806695
  • Measured at: 2026-03-11T08:10:09.486Z
  • Baseline source: history:870cf2806695
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.98 KiB +910 B (+1.02%) 277.30 KiB 76.41 KiB ▁▁▁▁▂▂▂▂▃▃▃█
react-router.full 91.17 KiB +1.09 KiB (+1.21%) 288.05 KiB 79.20 KiB ▁▁▁▁▂▂▂▂▂▂▂█
solid-router.minimal 35.34 KiB -1.08 KiB (-2.97%) 106.86 KiB 31.74 KiB ▆▆▆▆▇▇█████▁
solid-router.full 39.76 KiB -1,010 B (-2.42%) 120.14 KiB 35.68 KiB ▆▆▆▆▇▇█████▁
vue-router.minimal 53.22 KiB +959 B (+1.79%) 152.78 KiB 47.84 KiB ▁▁▁▁▂▂▂▂▂▂▂█
vue-router.full 58.24 KiB +1.16 KiB (+2.03%) 168.76 KiB 52.13 KiB ▁▁▁▁▂▂▂▂▂▂▂█
react-start.minimal 100.63 KiB +998 B (+0.98%) 316.49 KiB 87.05 KiB ▁▁▁▁▂▂▂▂▂▂▂█
react-start.full 103.99 KiB +1.02 KiB (+0.99%) 326.73 KiB 89.94 KiB ▁▁▁▁▂▂▂▂▂▂▂█
solid-start.minimal 47.67 KiB -1.09 KiB (-2.23%) 144.50 KiB 42.09 KiB ▆▆▆▆▇▇█████▁
solid-start.full 53.27 KiB -965 B (-1.74%) 160.68 KiB 46.87 KiB ▆▆▆▆▇▇█████▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6887

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6887

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6887

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6887

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6887

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6887

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6887

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6887

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6887

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6887

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6887

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6887

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6887

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6887

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6887

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6887

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6887

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6887

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6887

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6887

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6887

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6887

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6887

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6887

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6887

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6887

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6887

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6887

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6887

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6887

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6887

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6887

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6887

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6887

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6887

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6887

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6887

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6887

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6887

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6887

commit: ad32f01

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing refactor-signals-vue-link-from-arg-by-build-location (4611e7d) with refactor-signals (fb1e8b2)

Open in CodSpeed

@Sheraff Sheraff merged commit d5622bb into refactor-signals Mar 11, 2026
15 checks passed
@Sheraff Sheraff deleted the refactor-signals-vue-link-from-arg-by-build-location branch March 11, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant