refactor(solid-router): detached signals finalization registry

[Sheraff]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e448cd52-ec27-494c-915c-83164952f0e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor-signals-solid-finalization-registry

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit efe8435

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	9m 7s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	1m 29s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-03-11 10:52:10 UTC

[pkg-pr-new]

More templates

• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsc
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query
• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6885

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6885

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6885

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6885

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6885

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6885

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6885

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6885

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6885

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6885

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6885

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6885

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6885

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6885

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6885

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6885

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6885

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6885

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6885

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6885

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6885

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6885

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6885

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6885

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6885

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6885

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6885

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6885

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6885

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6885

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6885

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6885

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6885

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6885

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6885

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6885

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6885

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6885

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6885

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6885

commit: 2affa44

[github-actions]

Bundle Size Benchmarks

• Commit: 870cf2806695
• Measured at: 2026-03-11T10:44:01.559Z
• Baseline source: history:870cf2806695
• Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
react-router.minimal	87.98 KiB	+910 B (+1.02%)	277.30 KiB	76.41 KiB	▁▁▁▁▂▂▂▂▃▃▃█
react-router.full	91.17 KiB	+1.09 KiB (+1.21%)	288.08 KiB	79.21 KiB	▁▁▁▁▂▂▂▂▂▂▂█
solid-router.minimal	35.41 KiB	-1.02 KiB (-2.80%)	106.98 KiB	31.84 KiB	▆▆▆▆▇▇█████▁
solid-router.full	39.82 KiB	-945 B (-2.26%)	120.26 KiB	35.72 KiB	▆▆▆▆▇▇█████▁
vue-router.minimal	53.22 KiB	+959 B (+1.79%)	152.78 KiB	47.84 KiB	▁▁▁▁▂▂▂▂▂▂▂█
vue-router.full	58.24 KiB	+1.16 KiB (+2.03%)	168.76 KiB	52.13 KiB	▁▁▁▁▂▂▂▂▂▂▂█
react-start.minimal	100.63 KiB	+998 B (+0.98%)	316.51 KiB	87.08 KiB	▁▁▁▁▂▂▂▂▂▂▂█
react-start.full	104.01 KiB	+1.04 KiB (+1.01%)	326.75 KiB	89.92 KiB	▁▁▁▁▂▂▂▂▂▂▂█
solid-start.minimal	47.73 KiB	-1.02 KiB (-2.09%)	144.62 KiB	42.17 KiB	▆▆▆▆▇▇█████▁
solid-start.full	53.33 KiB	-905 B (-1.63%)	160.80 KiB	46.94 KiB	▆▆▆▆▇▇█████▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0620b83fba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codspeed-hq]

Merging this PR will not alter performance

✅ 6 untouched benchmarks

---

_{Comparing refactor-signals-solid-finalization-registry (efe8435) with refactor-signals (dd39707)}