refactor: replace package router.state reads with granular stores by Sheraff · Pull Request #6863 · TanStack/router

Sheraff · 2026-03-08T17:14:31Z

Summary

replace non-test router.state reads across packages/ with granular store accessors like router.stores.location.state, router.stores.statusCode.state, and match snapshot stores
update getLocationChangeInfo to accept (location, resolvedLocation?) so framework adapters can emit router events without depending on the full state object
align SSR helpers and start/query integrations with the granular store APIs used by the refactor-signals branch

Testing

not run in this environment (node_modules/Nx are unavailable)

coderabbitai · 2026-03-08T17:14:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 082b2cea-1d27-4f5a-a170-5961256bd690

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch opencode/silent-circuit

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-08T17:15:03Z

View your CI Pipeline Execution ↗ for commit 8437f3c

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	10m 8s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-08 17:25:58 UTC

github-actions · 2026-03-08T17:17:18Z

Bundle Size Benchmarks

Commit: 88fcbec9865c
Measured at: 2026-03-08T17:16:38.037Z
Baseline source: history:7003ccb50f7e
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	87.90 KiB	+1.06 KiB (+1.22%)	277.24 KiB	76.33 KiB	▁▁▂▂▂▂▂▂▂▂▂█
`react-router.full`	91.17 KiB	+1.29 KiB (+1.43%)	288.07 KiB	79.19 KiB	▁▁▂▂▂▂▂▂▂▂▂█
`solid-router.minimal`	35.07 KiB	-1.10 KiB (-3.05%)	106.04 KiB	31.50 KiB	▆▆█████████▁
`solid-router.full`	39.51 KiB	-1,011 B (-2.44%)	119.40 KiB	35.44 KiB	▆▆█████████▁
`vue-router.minimal`	53.05 KiB	+1.02 KiB (+1.96%)	152.18 KiB	47.60 KiB	▁▁▃▃▃▃▃▃▃▃▃█
`vue-router.full`	58.08 KiB	+1.24 KiB (+2.18%)	168.24 KiB	51.99 KiB	▁▁▂▂▂▂▂▂▂▂▂█
`react-start.minimal`	100.55 KiB	+1.15 KiB (+1.16%)	316.44 KiB	87.01 KiB	▁▁▂▂▂▂▂▂▂▂▂█
`react-start.full`	103.94 KiB	+1.16 KiB (+1.12%)	326.76 KiB	89.82 KiB	▁▁▂▂▂▂▂▂▂▂▂█
`solid-start.minimal`	47.40 KiB	-1.09 KiB (-2.24%)	143.68 KiB	41.94 KiB	▆▆█████████▁
`solid-start.full`	52.99 KiB	-991 B (-1.79%)	159.94 KiB	46.67 KiB	▆▆█████████▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-03-08T17:18:44Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6863

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6863

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6863

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6863

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6863

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6863

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6863

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6863

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6863

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6863

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6863

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6863

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6863

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6863

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6863

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6863

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6863

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6863

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6863

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6863

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6863

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6863

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6863

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6863

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6863

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6863

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6863

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6863

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6863

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6863

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6863

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6863

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6863

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6863

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6863

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6863

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6863

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6863

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6863

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6863

commit: e250a87

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8437f3c750

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/router-core/src/router.ts

codspeed-hq · 2026-03-08T17:33:14Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks

_{Comparing opencode/silent-circuit (8437f3c) with refactor-signals (dbc1745)}

refactor: replace package router.state reads with granular stores

8437f3c

github-actions bot added package: react-router package: router-core package: solid-router package: react-start package: solid-start package: start-server-core package: start-client-core package: router-ssr-query-core package: vue-router package: vue-start labels Mar 8, 2026

chatgpt-codex-connector bot reviewed Mar 8, 2026

View reviewed changes

packages/router-core/src/router.ts Show resolved Hide resolved

Sheraff merged commit 9252a5a into refactor-signals Mar 8, 2026
15 checks passed

Sheraff deleted the opencode/silent-circuit branch March 8, 2026 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: replace package router.state reads with granular stores#6863

refactor: replace package router.state reads with granular stores#6863
Sheraff merged 1 commit intorefactor-signalsfrom
opencode/silent-circuit

Sheraff commented Mar 8, 2026

Uh oh!

coderabbitai bot commented Mar 8, 2026

Review skipped

Uh oh!

nx-cloud bot commented Mar 8, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

pkg-pr-new bot commented Mar 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Sheraff commented Mar 8, 2026

Summary

Testing

Uh oh!

coderabbitai bot commented Mar 8, 2026

Review skipped

Uh oh!

nx-cloud bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 8, 2026

Bundle Size Benchmarks

Uh oh!

pkg-pr-new bot commented Mar 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 8, 2026

Merging this PR will not alter performance

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloud bot commented Mar 8, 2026 •

edited

Loading