Skip to content

fix(router): restore new test regressions#6859

Merged
Sheraff merged 2 commits intorefactor-signalsfrom
opencode/tidy-garden
Mar 8, 2026
Merged

fix(router): restore new test regressions#6859
Sheraff merged 2 commits intorefactor-signalsfrom
opencode/tidy-garden

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Mar 8, 2026

Summary

  • restore structural sharing in React useLocation while keeping the hook on the direct location store path
  • thread Vue Link transition state into rendered props so slot children receive isTransitioning during pending navigation
  • keep the new tests added on main green on top of refactor-signals

Testing

  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/react-router:test:unit --outputStyle=stream --skipRemoteCache -- tests/useLocation.test.tsx
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/vue-router:test:unit --outputStyle=stream --skipRemoteCache -- tests/link.test.tsx -t "Link slot receives isTransitioning during pending navigation"
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/solid-router:test:unit --outputStyle=stream --skipRemoteCache -- tests/server/errorComponent.test.tsx

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3cbb5084-d0f2-4d16-ba74-4e0561488bac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch opencode/tidy-garden

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 8, 2026

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 6181aca

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 2m 12s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-08 13:12:00 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

Bundle Size Benchmarks

  • Commit: 446d7973cfc5
  • Measured at: 2026-03-08T12:52:35.845Z
  • Baseline source: history:446d7973cfc5
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.91 KiB +1.07 KiB (+1.24%) 277.16 KiB 76.38 KiB ▁▁▁▂▂▂▂▂▂▂▂█
react-router.full 91.18 KiB +1.30 KiB (+1.44%) 287.99 KiB 79.14 KiB ▁▁▁▂▂▂▂▂▂▂▂█
solid-router.minimal 35.26 KiB -930 B (-2.51%) 106.65 KiB 31.64 KiB ▆▆▆████████▁
solid-router.full 39.73 KiB -786 B (-1.90%) 120.25 KiB 35.58 KiB ▅▅▅████████▁
vue-router.minimal 53.07 KiB +1.03 KiB (+1.98%) 152.09 KiB 47.64 KiB ▁▁▁▂▂▂▂▂▂▂▂█
vue-router.full 58.10 KiB +1.25 KiB (+2.20%) 168.15 KiB 52.02 KiB ▁▁▁▂▂▂▂▂▂▂▂█
react-start.minimal 100.56 KiB +1.15 KiB (+1.16%) 316.35 KiB 86.99 KiB ▁▁▁▂▂▂▂▂▂▂▂█
react-start.full 103.94 KiB +1.16 KiB (+1.13%) 326.66 KiB 89.87 KiB ▁▁▁▂▂▂▂▂▂▂▂█
solid-start.minimal 47.58 KiB -929 B (-1.87%) 144.28 KiB 42.07 KiB ▆▆▆████████▁
solid-start.full 53.20 KiB -782 B (-1.42%) 160.78 KiB 46.84 KiB ▅▅▅████████▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 8, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6859

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6859

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6859

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6859

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6859

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6859

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6859

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6859

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6859

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6859

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6859

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6859

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6859

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6859

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6859

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6859

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6859

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6859

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6859

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6859

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6859

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6859

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6859

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6859

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6859

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6859

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6859

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6859

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6859

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6859

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6859

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6859

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6859

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6859

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6859

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6859

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6859

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6859

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6859

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6859

commit: e614bb0

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 8, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing opencode/tidy-garden (6181aca) with refactor-signals (e807c00)

Open in CodSpeed

@Sheraff Sheraff merged commit 99918ca into refactor-signals Mar 8, 2026
15 of 17 checks passed
@Sheraff Sheraff deleted the opencode/tidy-garden branch March 8, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant